Skip to content

Commit

Permalink
Fix last PeleC codeql (AMReX-Combustion#428)
Browse files Browse the repository at this point in the history
  • Loading branch information
marchdf authored Oct 4, 2023
1 parent 8fd8071 commit 8099835
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Docs/sphinx/CvodeInPP.rst
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ ReactEval_C example with a subset of the various available CVODE linear solvers.
+-------------------------------+-----------------+----------------+-------------+----------------+-----------------+


The same series of tests are performed for a mixture of n-dodecane and air (see :ref:`sec:subsReactEvalCvode`), the configuration being otherwise the same as in the methane/air case. Results are sumarized in Table :numref:`tab:RunsReactEvalCvodeDOD`. The overall tendencies remain similar. Note that the non-preconditioned GMRES solver becomes very inefficient for this larger system. Here also, the direct sparse solve --which relies upon the KLU library, does not seem to provide additional time savings. The fill-in pattern is :math:`70 \%`.
The same series of tests are performed for a mixture of n-dodecane and air (see :ref:`sec:subsReactEvalCvode`), the configuration being otherwise the same as in the methane/air case. Results are summarized in Table :numref:`tab:RunsReactEvalCvodeDOD`. The overall tendencies remain similar. Note that the non-preconditioned GMRES solver becomes very inefficient for this larger system. Here also, the direct sparse solve --which relies upon the KLU library, does not seem to provide additional time savings. The fill-in pattern is :math:`70 \%`.

.. _tab:RunsReactEvalCvodeDOD:

Expand Down Expand Up @@ -663,7 +663,7 @@ The input file
The Results
^^^^^^^^^^^

Results are sumarized in Table :numref:`tab:RunsReactEvalCvodeDRMGPU`.
Results are summarized in Table :numref:`tab:RunsReactEvalCvodeDRMGPU`.


.. _tab:RunsReactEvalCvodeDRMGPU:
Expand Down
2 changes: 1 addition & 1 deletion Docs/sphinx/Utility.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This code has two runtime parameters that may be set in the input file: ::
pmf.datafile = pmf.dat
pmf.do_cellAverage = 1

The first parameter specifies the path to the PMF data file. This file contains a two-line header followed by whitespace-delimited data columns in the order: position (cm), temperature (K), velocity (cm/s), density(g/cm3), species mole fractions. Sample files are provided in the relevant PeleLMeX (and PeleC) examples, and the procedure to generate these files with a provided script is described below. The second parameter specifies whether the PMF code does a finite volume-style integral over the querried cell (``pmf.do_cellAverage = 1``) or whether the code finds an interpolated value at the midpoint of the querried cell (``pmf.do_cellAverage = 0``)
The first parameter specifies the path to the PMF data file. This file contains a two-line header followed by whitespace-delimited data columns in the order: position (cm), temperature (K), velocity (cm/s), density(g/cm3), species mole fractions. Sample files are provided in the relevant PeleLMeX (and PeleC) examples, and the procedure to generate these files with a provided script is described below. The second parameter specifies whether the PMF code does a finite volume-style integral over the queried cell (``pmf.do_cellAverage = 1``) or whether the code finds an interpolated value at the midpoint of the queried cell (``pmf.do_cellAverage = 0``)

Generating a PMF file
~~~~~~~~~~~~~~~~~~~~~
Expand Down
4 changes: 4 additions & 0 deletions Support/Mechanism/Models/Null/mechanism.H
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,21 @@ void SPARSITY_PREPROC_SYST_SIMPLIFIED_CSR(
int* colVals, int* rowPtr, const int* consP, int base);

// inverse molecular weights
#ifdef AMREX_USE_GPU
AMREX_GPU_CONSTANT const amrex::Real global_imw[1] = {
1.0,
};
#endif
const amrex::Real h_global_imw[1] = {
1.0,
};

// molecular weights
#ifdef AMREX_USE_GPU
AMREX_GPU_CONSTANT const amrex::Real global_mw[1] = {
1.0,
};
#endif
const amrex::Real h_global_mw[1] = {
1.0,
};
Expand Down

0 comments on commit 8099835

Please sign in to comment.