Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform tests against zip path first to help with long paths #792

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Perform tests against zip path first to help with long paths #792

merged 1 commit into from
Aug 10, 2016

Conversation

damieng
Copy link
Contributor

@damieng damieng commented Aug 10, 2016

This tests the zip entry path against the regex to determine whether it is in the lib folder and should be extracted or not.

Previously the code was using the full path which causes paths that were already close to the limit to go over as it also has lib\net45 etc in it. It also seems that the old code would extract files it shouldn't if the word "lib" appeared in the output path, e.g. c:\users\libby)

@anaisbetts
Copy link
Contributor

#blessed

@anaisbetts anaisbetts merged commit a625aa8 into Squirrel:master Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants