Skip to content

Output the details when failed to sign #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Output the details when failed to sign #1889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4f5945
Output the details when failed to sign
DamonYuRC Sep 14, 2024
589f835
Merge branch 'develop' into develop-output-signtools-exception-details
DamonYu6 Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Update/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,8 @@ static async Task signPEFile(string exePath, string signingOpts)
(?=\s+) #positive look ahead for white space(s)
"
).Replace(signingOpts, "/p ********");
var msg = String.Format("Failed to sign, command invoked was: '{0} sign {1} {2}'",
exe, optsWithPasswordHidden, exePath);
var msg = String.Format("Failed to sign, command invoked was: '{0} sign {1} {2}' \n\nOutput from signtool.exe was:\n{3}",
exe, optsWithPasswordHidden, exePath, processResult.Item2);

throw new Exception(msg);
} else {
Expand Down
Loading