Skip to content

Commit

Permalink
Fixes after merges, prettier globally applied
Browse files Browse the repository at this point in the history
  • Loading branch information
Anarios committed Jul 25, 2022
1 parent 58161ac commit b0cb173
Show file tree
Hide file tree
Showing 47 changed files with 2,183 additions and 1,942 deletions.
122 changes: 60 additions & 62 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,65 +3,63 @@ description: File a bug report!
# title: "(Bug): "
labels: ["bug"]
body:
- type: input
attributes:
label: Browser
description: Which browser are you using?
placeholder: "Example: Google Chrome"
validations:
required: true
- type: input
attributes:
label: Browser Version
description: Which browser version are you using?
placeholder: "Example: Chromium v95"
validations:
required: true
- type: dropdown
attributes:
label: "Extension or Userscript?"
options:
- Extension
- Userscript
validations:
required: true
- type: input
attributes:
label: Extension/Userscript Version
description: Which extension/userscript version are you using?
placeholder: "Example: Version 0.0.0.1"
validations:
required: true
- type: input
attributes:
label: Video link where you see the problem
description: Video link where you see the problem
placeholder: "Example: https://www.youtube.com/watch?v=s4-gMgdsnHQ"
validations:
required: true
- type: textarea
attributes:
label: What happened?
description: Also tell us, what did you expect to happen?
placeholder: Tell us what you see!
value: "A bug happened!"
validations:
required: true
- type: textarea
attributes:
label: How to reproduce/recreate?
description: Detailed steps to reproduce/recreate it.
placeholder: "We need to be able to reproduce/recreate that bug/event in order to fix it. Please write the steps in detail."
value: "Tell us how it happened with detailed steps for us."
validations:
required: true
- type: dropdown
attributes:
label: "Will you be available for follow-up questions to help developers diagnose & fix the issue?"
options:
- "Yes"
- "No"
validations:
required: true


- type: input
attributes:
label: Browser
description: Which browser are you using?
placeholder: "Example: Google Chrome"
validations:
required: true
- type: input
attributes:
label: Browser Version
description: Which browser version are you using?
placeholder: "Example: Chromium v95"
validations:
required: true
- type: dropdown
attributes:
label: "Extension or Userscript?"
options:
- Extension
- Userscript
validations:
required: true
- type: input
attributes:
label: Extension/Userscript Version
description: Which extension/userscript version are you using?
placeholder: "Example: Version 0.0.0.1"
validations:
required: true
- type: input
attributes:
label: Video link where you see the problem
description: Video link where you see the problem
placeholder: "Example: https://www.youtube.com/watch?v=s4-gMgdsnHQ"
validations:
required: true
- type: textarea
attributes:
label: What happened?
description: Also tell us, what did you expect to happen?
placeholder: Tell us what you see!
value: "A bug happened!"
validations:
required: true
- type: textarea
attributes:
label: How to reproduce/recreate?
description: Detailed steps to reproduce/recreate it.
placeholder: "We need to be able to reproduce/recreate that bug/event in order to fix it. Please write the steps in detail."
value: "Tell us how it happened with detailed steps for us."
validations:
required: true
- type: dropdown
attributes:
label: "Will you be available for follow-up questions to help developers diagnose & fix the issue?"
options:
- "Yes"
- "No"
validations:
required: true
67 changes: 33 additions & 34 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,36 @@ description: Request or suggest a new feature!
# title: "(Feature Request): "
labels: ["enhancement"]
body:
- type: dropdown
attributes:
label: Extension or Userscript?
options:
- Extension
- Userscript
- Both
validations:
required: true
- type: textarea
attributes:
label: Request or suggest a new feature!
placeholder: I want to suggest...
validations:
required: true
- type: textarea
attributes:
label: Ways to implement this!
placeholder: We can implement it by...
- type: checkboxes
attributes:
label: Can you work on this?
options:
- label: "Yes"
- label: "No"
- type: dropdown
attributes:
label: "Will you be available for follow-up questions to help developers implement this?"
options:
- "Yes"
- "No"
validations:
required: true

- type: dropdown
attributes:
label: Extension or Userscript?
options:
- Extension
- Userscript
- Both
validations:
required: true
- type: textarea
attributes:
label: Request or suggest a new feature!
placeholder: I want to suggest...
validations:
required: true
- type: textarea
attributes:
label: Ways to implement this!
placeholder: We can implement it by...
- type: checkboxes
attributes:
label: Can you work on this?
options:
- label: "Yes"
- label: "No"
- type: dropdown
attributes:
label: "Will you be available for follow-up questions to help developers implement this?"
options:
- "Yes"
- "No"
validations:
required: true
5 changes: 2 additions & 3 deletions .github/workflows/commentCommands.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: commentCommands
on:
issue_comment:
types: created

jobs:

jobs:
assign-commenter:
runs-on: ubuntu-latest
if: |
Expand Down Expand Up @@ -35,7 +34,7 @@ jobs:
-H "Accept: application/vnd.github+json" \
-H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/comments \
-d '{"body":"This issue is put on hold due to low quality. No reviews or fixes will be performed at this time. Eventually, it will be closed. While we appreciate your effort writing, we are not able to further investigate it. Please improve it by writing a better title or providing more details, and you may re-open it."}'
-d '{"body":"This issue is put on hold due to low quality. No reviews or fixes will be performed at this time. Eventually, it will be closed. While we appreciate your effort writing, we are not able to further investigate it. Please improve it by writing a better title or providing more details, and you may re-open it."}'
add-label-duplicate:
runs-on: ubuntu-latest
if: |
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/weblint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,22 @@ name: Website Lint

on:
push:
branches: [ main ]
branches: [main]
paths:
- Website/**

pull_request:
branches: [ main ]
branches: [main]
paths:
- Website/**

jobs:
weblint:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@main
- run: npm install
working-directory: Website
- run: npm run lint
working-directory: Website
- uses: actions/checkout@main
- run: npm install
working-directory: Website
- run: npm run lint
working-directory: Website
9 changes: 8 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Read this in other languages: [Français](CONTRIBUTINGfr.md)
Thank you for investing your time in contributing to our project! All your changes will be reflected in the next version of the extension (or the [website](https://www.returnyoutubedislike.com/)).

## Getting Started

Please use Prettier with default settings for formatting.

#### Prerequisites
Expand Down Expand Up @@ -38,22 +39,28 @@ Congratulations, You are now ready to develop!

If you are new to developing Chrome extensions, or need extra help, please see [this YouTube tutorial](https://www.youtube.com/watch?v=mdOj6HYE3_0)


### Issues

#### Opening a new issue

If you have any issues with the extension, please search to make sure the issue isn't already reported. If it isn't, open an issue, using the issue form is highly recommended but not mandatory.

#### Solving an issue

If you found an issue that you feel you might be able to solve, don't be shy. Open a PR with the fix and make sure to mention the issue you are fixing.

### Feature Request

#### Opening a new feature request

If you have an idea for the extension, feel free to open a feature request, but please search it before to make sure the feature isn't already suggested. Using the feature form is highly recommended but not mandatory

#### Implementing a feature request

If you found a feature that you feel you might be able to implement, don't be shy. Open a PR with the fix and make sure to mention the feature you are implementing.

### What PRs do we accept?

- Issue fixes.
- Feature implementation.
- Typos or better and easier words to use.
Expand Down
12 changes: 10 additions & 2 deletions CONTRIBUTINGfr.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ Lisez ceci dans d'autres langues : [English](CONTRIBUTING.md)
Merci d'investir votre temps pour contribuer à notre projet ! Toutes vos modifications seront prises en compte dans la prochaine version de l'extension (ou du site web).

## Pour commencer

Veuillez utiliser [Prettier](https://prettier.io/) avec les paramètres par défaut pour le formatage du code.

#### Prérequis

Vous devez avoir installé node et npm pour créer la version bundle depuis le code source.

Versions utilisées lors de la mise en place :
Expand Down Expand Up @@ -37,23 +39,29 @@ Félicitations, vous êtes maintenant prêt·e à développer !

Si vous n'avez jamais développé d'extensions pour Chrome ou si vous avez besoin d'une aide supplémentaire, consultez [ce tutoriel YouTube](https://www.youtube.com/watch?v=mdOj6HYE3_0) (en anglais).


### Problèmes (aussi appelé issues en anglais)

#### Signaler un problème

Si vous rencontrez des problèmes avec l'extension, vérifiez que le problème n'a pas déjà été signalé. Si ce n'est pas le cas, [signalez le problème](https://github.com/Anarios/return-youtube-dislike/issues/new?assignees=&labels=bug&template=bug.yml&title=%28Bug%29%3A+), en utilisant le formulaire qui est fortement recommandé mais pas obligatoire.

#### Résoudre un problème

Si vous avez trouvé un problème que vous pensez pouvoir résoudre, ne soyez pas timide. Ouvrez une [PR](https://github.com/Anarios/return-youtube-dislike/pulls) [(C'est quoi ?)](https://blog.zenika.com/2017/01/24/pull-request-demystifie/) avec la solution et assurez-vous de mentionner le problème que vous résolvez (écrivez # puis le numéro de l'issue).

### Demande de fonctionnalité (aussi appelé feature request en anglais)

#### Ouverture d'une nouvelle demande de fonctionnalité

Si vous avez une idée pour l'extension, n'hésitez pas à [ouvrir une demande de fonctionnalité](https://github.com/Anarios/return-youtube-dislike/issues/new?assignees=&labels=enhancement&template=feature-request.yml&title=%28Feature+Request%29%3A+), mais veuillez effectuer une recherche préalable pour vous assurer que la fonctionnalité n'est pas déjà proposée. L'utilisation du formulaire de demande de fonctionnalité est fortement recommandée mais pas obligatoire.

#### Implémenter une demande de fonctionnalité

Si vous avez trouvé une fonctionnalité que vous pensez pouvoir mettre en œuvre, ne soyez pas timide. Ouvrez une [PR](https://github.com/Anarios/return-youtube-dislike/pulls) [(C'est quoi ?)](https://blog.zenika.com/2017/01/24/pull-request-demystifie/) avec le correctif et assurez-vous de mentionner la fonctionnalité que vous implémentez (écrivez # puis le numéro de l'issue).

### Quels PR acceptons-nous ?

- Correction de problèmes.
- Implémentation de fonctionnalités.
- Fautes de frappe ou utilisation de mots plus simples et plus efficaces.
- Contributions au site web.
- Contributions au site web.
Loading

0 comments on commit b0cb173

Please sign in to comment.