Skip to content
This repository was archived by the owner on Oct 7, 2022. It is now read-only.

Conversation

@laysakura
Copy link
Collaborator

@laysakura laysakura commented Oct 6, 2022

Issue number and link

Refs: SpringQL#247

Test the PoC of the fix in this repo.

Describe your changes

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 84.11% // Head: 84.00% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (7a5c902) compared to base (c04ebaf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   84.11%   84.00%   -0.11%     
==========================================
  Files         219      219              
  Lines       12789    12789              
==========================================
- Hits        10758    10744      -14     
- Misses       2031     2045      +14     
Impacted Files Coverage Δ
...ql_processor/sql_parser/pest_parser_impl/helper.rs 78.57% <0.00%> (-14.29%) ⬇️
...task/pump_subtask/query_subtask/collect_subtask.rs 96.66% <0.00%> (-1.67%) ⬇️
...e/src/sql_processor/sql_parser/pest_parser_impl.rs 87.68% <0.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@laysakura laysakura marked this pull request as ready for review October 7, 2022 00:07
@laysakura laysakura merged commit feff2cd into main Oct 7, 2022
@laysakura laysakura deleted the fix/cargo-publish branch October 7, 2022 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants