jshinting

Spottt · Nov 11, 2013 · d892a9b · d892a9b
1 parent 374ad40
commit d892a9b
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 7 deletions.
diff --git a/.jshintignore b/.jshintignore
@@ -0,0 +1,2 @@
+node_modules
+examples/**/node_modules/*
diff --git a/.jshintrc b/.jshintrc
@@ -0,0 +1,47 @@
+{
+
+	// environment
+	"browser": true,
+	"node": true,
+	"strict": true,
+
+	"globals": {
+		"define": true,
+		"L": true,
+		"chai": true,
+		"it": true,
+		"describe": true,
+		"beforeEach": true,
+		"afterEech": true
+	},
+
+	// code style
+	"bitwise": true,
+	"camelcase": true,
+	"curly": true,
+	"eqeqeq": true,
+	"forin": false,
+	"immed": true,
+	"latedef": true,
+	"newcap": true,
+	"noarg": true,
+	"noempty": true,
+	"nonew": true,
+	"undef": true,
+	"unused": true,
+	"quotmark": "single",
+	"expr": true,
+
+	// whitespace
+	"indent": 4,
+	"trailing": true,
+	"white": true,
+	"smarttabs": true,
+	"maxlen": 120
+
+	// code simplicity - not enforced but nice to check from time to time
+	// "maxstatements": 20,
+	// "maxcomplexity": 5
+	// "maxparams": 4,
+	// "maxdepth": 4
+}
diff --git a/examples/leaflet-image/index.js b/examples/leaflet-image/index.js
@@ -31,11 +31,11 @@ L.geoJson(gj).addTo(map);
 
 
 console.log('Save to image using leaflet-image...');
-leafletImage(map, function(err, canvas) {
+leafletImage(map, function (err, canvas) {
 	var out = fs.createWriteStream(__dirname + '/test.png');
 	var stream = canvas.pngStream();
 
-	stream.on('data', function(chunk){
+	stream.on('data', function (chunk) {
 		out.write(chunk);
 	});
 

diff --git a/index.js b/index.js
@@ -6,7 +6,7 @@
 
 'use strict';
 
-var jsdom = require('jsdom').jsdom
+var jsdom = require('jsdom').jsdom;
 
 // make some globals to fake browser behaviour.
 GLOBAL.document = jsdom('<html><head></head><body></body></html>');

diff --git a/test/test.js b/test/test.js
@@ -3,7 +3,6 @@
 var L = require('../index.js');
 var chai = require('chai').should();
 
-
 describe('Leaflet-headless', function () {
 
 	describe('basic functions', function () {
@@ -37,12 +36,12 @@ describe('Leaflet-headless', function () {
 			map.setView([52, 4], 10);
 
 			L.tileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
-				attribution: '&copy; <a href="http://openstreetmap.org">OpenStreetMap</a> contributors, <a href="http://creativecommons.org/licenses/by-sa/2.0/">CC-BY-SA</a>'
+				attribution: '&copy; <a href="http://openstreetmap.org">OpenStreetMap</a> contributors, ' +
+					'<a href="http://creativecommons.org/licenses/by-sa/2.0/">CC-BY-SA</a>'
 			}).addTo(map);
-		})
+		});
 
 		it('has some working imagePath');
 
 	});
-
 });