Removing Guava usage #2246
Merged
Removing Guava usage #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about plugins? If each plugin will add Guava to JAR manually, there will be version conflicts. |
Member
Author
We're not removing guava as part of the API set of libraries, we're just removing our usage of them in the API. There's also an overall issue of "we're stuck with the versions of guava based on the MC implementation" but other implementations (like lantern) are irrespective of Minecraft's version dependencies. |
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
gabizou
force-pushed
the
api8/de-guavafy
branch
from
d6dda4a to
2d69028
Compare
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty basic premise, we've got issues with relying on guava, and as Configurate is migrating away from Guava altogether, so shall we (on the basis that we don't really use too much of guava, this is a good chance for cleanup as well).
@zml2008 has got more to do with migrating our usage of TypeTokens.