Skip to content

Change GameProfileManager method signature to return a map #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zidane merged 1 commit into from
Aug 24, 2020
Merged

Change GameProfileManager method signature to return a map #2211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/org/spongepowered/api/profile/GameProfileManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@

import java.io.IOException;
import java.util.Collection;
import java.util.Map;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
Expand Down Expand Up @@ -137,7 +139,7 @@ default CompletableFuture<GameProfile> get(String name) {
* @param useCache true to perform a cache lookup first
* @return The result of the request
*/
CompletableFuture<Collection<GameProfile>> getAllById(Iterable<UUID> uniqueIds, boolean useCache);
CompletableFuture<Map<UUID, Optional<GameProfile>>> getAllById(Iterable<UUID> uniqueIds, boolean useCache);

/**
* Gets a collection of {@link GameProfile}s by their user names
Expand All @@ -151,7 +153,7 @@ default CompletableFuture<GameProfile> get(String name) {
* @param useCache true to perform a cache lookup first
* @return The result of the request
*/
CompletableFuture<Collection<GameProfile>> getAllByName(Iterable<String> names, boolean useCache);
CompletableFuture<Map<String, Optional<GameProfile>>> getAllByName(Iterable<String> names, boolean useCache);

/**
* Fills a {@link GameProfile}.
Expand Down