Fix event-gen factory

[ImMorpheus]

Fix #1526

See #1977

I've updated the PR (most of those events are gone).

[Zidane]

@ImMorpheus Put these on the lifecycle file exclusions please.

[dualspiral]

How is @NoFactoryMethod different from an exclude directive in the Gradle file? If there is no difference, I'd rather we just add things to the exclude directive, especially as we want to move the factory generation to Common, reducing the exposure of the generator to the API itself.

[Zidane]

@dualspiral That is a good point, didn't even think about that.

[ImMorpheus]

How is @NoFactoryMethod different from an exclude directive in the Gradle file? If there is no difference, I'd rather we just add things to the exclude directive, especially as we want to move the factory generation to Common, reducing the exposure of the generator to the API itself.

The exclude directive targets a java file. The annotation targets a type.
This means that

SpongeAPI/src/main/java/org/spongepowered/api/event/action/CollideEvent.java

Lines 37 to 47 in dc2186f

	public interface CollideEvent extends Event, Cancellable {
	/**
	* Fired after an {@link Entity} or {@link BlockSnapshot} impact with each
	* other.
	*
	* <p>Note: this should only fire once after the first impact.</p>
	*/
	@NoFactoryMethod
	interface Impact extends CollideEvent {

can't be implemented using the exclude directive AFAIK.

I'll move the other ones since this doesn't apply to them.

[gabizou]

LGTM