[API-8] Add missing Living value accessors #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidane
reviewed
Jul 2, 2020
ItsDoot
changed the title
ItsDoot
changed the title
Zidane
reviewed
Jul 4, 2020
| * {@link Keys#ACTIVE_ITEM} | ||
| * @return The active item, such as food being eaten | ||
| */ | ||
| default Value.Mutable<ItemStackSnapshot> activeItem() { |
Member
There was a problem hiding this comment.
Can you give some guidance on how the Values in these interfaces should be returned to consumers?
Like, should they always be Value.Mutable? Just Value? Does it depend on what it is returning and what you can do with it in the game?
Member
There was a problem hiding this comment.
I am preferring they're always Mutable from entities. It does make sense that they are reflective of their Key variables, but at the end of the day, the developer is likely to want to mutate the value and maybe offer it back, or present it to another entity after mutation.
ItsDoot
force-pushed
the
api8/eyeposition
branch
from
55ce942 to
b7dbd5e
Compare
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds value accessors for the following keys to
Living:ABSORPTIONACTIVE_ITEMEYE_HEIGHTEYE_POSITIONFALL_DISTANCEMAX_AIRREMAINING_AIRSTUCK_ARROWSWALKING_SPEED