[API-8] Adjust NamedCatalogType and NamedCatalogBuilder interfaces for expectations #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things this PR does:
If we were to keep this default implementation, we're right back at the issue of api 7's
CatalogType. If plugin devs want their catalog types to have names, the names should be meaningful.I expect that most plugin devs will not care about translations for their catalog type names, and will just want quick and dirty (yet still meaningful) names.