Conversation
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
Cybermaxke
reviewed
Apr 15, 2020
| * or | ||
| * The size of a {@link Phantom}. In vanilla, this ranges between 0 and 64. | ||
| */ | ||
| public static final Supplier<Key<BoundedValue<Integer>>> SIZE = Sponge.getRegistry().getCatalogRegistry().provideSupplier(Key.class, "SIZE"); |
Contributor
There was a problem hiding this comment.
I wouldn't name it SIZE, since it will likely conflict with possible future keys. So maybe just SLIME_SIZE and PHANTOM_SIZE, but I'm not sure
Contributor
Author
There was a problem hiding this comment.
yeah I'm not sure either
Cybermaxke
reviewed
Apr 15, 2020
Contributor
|
I added some comments related to key naming, we should try to name them that there won't be a lot of conflicts in the future. I will revisit some of them when I finish my duration PR, but that's nothing to worry about right now. For |
Faithcaio
force-pushed
the
api8/keys
branch
4 times, most recently
from
cc867e3 to
b641fc9
Compare
Cybermaxke
reviewed
May 2, 2020
JBYoshi
reviewed
May 5, 2020
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
SpongePowered/Sponge#2545