Skip to content

Remove HandInteractEvent and sub events#2096

Merged
Zidane merged 1 commit intoSpongePowered:api-8from
ImMorpheus:hand-events
Jul 2, 2020
Merged

Remove HandInteractEvent and sub events#2096
Zidane merged 1 commit intoSpongePowered:api-8from
ImMorpheus:hand-events

Conversation

@ImMorpheus
Copy link
Contributor

We have 3 way to get the hand used in an interact event:

  1. a method: HandInteractEvent#getHandType
  2. specific sub events: X.MainHand and X.OffHand
  3. EventContextKeys.USED_HAND

This is overly verbose, unnecessary and confusing to a degree.
This PR removes 1. and 2.

@ImMorpheus ImMorpheus added system: event type: enhancement api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) labels Feb 28, 2020
@ImMorpheus ImMorpheus requested a review from Zidane February 28, 2020 19:29
@dualspiral
Copy link
Contributor

dualspiral commented Feb 29, 2020

  1. may need to return(ish, in a different form), as per Enhance Visibility of EventContextKey Usage #1975

@Zidane
Copy link
Member

Zidane commented Jul 2, 2020

@ImMorpheus Status on this?

@ImMorpheus
Copy link
Contributor Author

ImMorpheus commented Jul 2, 2020

Nothing to add on my end.

EDIT: I didn't mean to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) system: event type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants