[WIP] API 8.0.0 #1995
Closed
[WIP] API 8.0.0 #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidane
requested review from
Deamon5550,
Faithcaio,
gabizou,
kashike and
stephan-gh
as code owners
Contributor
|
Comments from 3a58391 still need to be addressed. |
Zidane
force-pushed
the
api-8
branch
13 times, most recently
from
d37f8b7 to
cf7691a
Compare
* Added Ticks to shield the notion of a tick from consumers * Removed TemporalUnits * Renamed Task methods delayTicks and intervalTicks to delay and interval as they now take a Ticks object Try to tidy up a description a little Add notion of MinecraftDayTime for DayTime Licence Add Ticks to appropriate data keys Make Ticks engine aware (but not engine dependent itself) Make MinecraftDayTime Engine aware
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Offering no longer resolves game profile properties. Auto resolving is problematic because it can potentially block the main thread. So it now needs to be done explicitly. Make ProfileNotFoundException a RuntimeException.
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
…lders Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
This brings in line all of the changes needed for the base events to be thrown and called. The various functions are verified to have been either updated or not needing changes. There are some todo's required regarding the extra context keys, but the overall functionality remains intact. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
This is purely for a marker to see what is changing. We're not intending on merging the branches into each other.
stable-7will be merged in to keepapi-8up to date with whatever small code effects take place.