Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 32 bit compatible pack() format #126

Closed
wants to merge 1 commit into from
Closed

Conversation

staabm
Copy link

@staabm staabm commented Jan 5, 2019

should fix #125

@staabm
Copy link
Author

staabm commented Jan 5, 2019

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7757438 on staabm:patch-1 into 1438831 on Spomky-Labs:v9.0.

@staabm
Copy link
Author

staabm commented Jan 5, 2019

I was not able to verify thix fix still works for php 64bit, as I dont have it available on my machine. lets see what the unit tests think.

in my 32bit installation at least I can generate OTP values now, which wasn't possible before.

@Spomky
Copy link
Member

Spomky commented Jan 5, 2019

Hi,

Thank your for this PR.
Can you have a look at #107? It looks like this PR is the reason for this issue.
If it works fine on your 32bits env, I will revert that PR

@staabm
Copy link
Author

staabm commented Jan 5, 2019

thx for the fast reply. after reverting the change of #107 it works for me.

Spomky added a commit that referenced this pull request Jan 6, 2019
This PR reverts the changes from #107.
It should solve #126 / #125
@Spomky Spomky mentioned this pull request Jan 6, 2019
Spomky added a commit that referenced this pull request Jan 6, 2019
This PR reverts the changes from #107.
It should solve #126 / #125
@Spomky
Copy link
Member

Spomky commented Jan 6, 2019

Should be fixed in v9.1.3.
Feel free to open another issue if there is something wrong with this new release.

@Spomky Spomky closed this Jan 6, 2019
@staabm staabm deleted the patch-1 branch January 6, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32bit php compat
3 participants