-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise supported php version to 8.1+ and symfony version to 6.x, drop … #60
Conversation
…support for older versions
This looks really promising, any particular reason you removed thecodingmachine/safe for "safe" sprintf? Sprintf seems to be used only for Exception messages so maybe not that big of a deal? |
Since PHP 8.x sprintf itself is safe, so thecodingmachine/safe is not needed anymore. |
Excellent. Many thanks for this PR. |
Would it be possible to:
Do you think it is reasonable to require at least PHP8.1 for such bundle? |
Since I have neither excperience with php-cs-fixer nor easy-coding-standard (we are only using phpcs), I don't know if this should be part of this PR. On the other hand it would of course be great to move to easy-coding-standard and rector in the long run. Maybe this could be developed in a seperate branch? And for PHP 8.1 - I see no reason, Symfony has 8.0+, and like I said above, all tests are green for now. But it would of course be possible. |
Ok @temp. Thank you for your advices. |
I've just created a new branch v4.0 and merged another PR. |
OK let's go with this new branch. |
Awesome! |
@Spomky when will you create a release for 4.0, after your rector/ecs changes? |
It seems to be ready now. I don't see any other modification. |
Nice! Will try it out when a tagged release is available. |
Tagged! |
…support for older versions
Sadly I wasn't able to create a version that supports symfony 5+6 and older php versions.
Maybe this could be released as a new major version 4.0, older php/symfony version could still use 3.x.
A lot of stuff has been updated:
Removed the travis-tests and moved to github actions.
Tested in our project that uses azure based authentication, works fine with symfony 6.