Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise supported php version to 8.1+ and symfony version to 6.x, drop … #60

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

temp
Copy link
Contributor

@temp temp commented Apr 6, 2022

…support for older versions

Sadly I wasn't able to create a version that supports symfony 5+6 and older php versions.
Maybe this could be released as a new major version 4.0, older php/symfony version could still use 3.x.

A lot of stuff has been updated:

  • switch to friends-of-behat packages for the behat-extensions
  • upgrade web-token/* to 3.x
  • upgrade safe to 2.x
  • upgrade phpstan to 1.x

Removed the travis-tests and moved to github actions.

Tested in our project that uses azure based authentication, works fine with symfony 6.

@lucasgranberg
Copy link

This looks really promising, any particular reason you removed thecodingmachine/safe for "safe" sprintf? Sprintf seems to be used only for Exception messages so maybe not that big of a deal?

@temp
Copy link
Contributor Author

temp commented Apr 12, 2022

Since PHP 8.x sprintf itself is safe, so thecodingmachine/safe is not needed anymore.
And PHP 8.0 is required for symfony/*
See https://github.com/thecodingmachine/safe/blob/master/deprecated/strings.php#L299

@Spomky
Copy link
Member

Spomky commented Apr 12, 2022

Excellent. Many thanks for this PR.
This is something I wanted to do but had no time to dig into it

@Spomky
Copy link
Member

Spomky commented Apr 12, 2022

Would it be possible to:

Do you think it is reasonable to require at least PHP8.1 for such bundle?

@temp
Copy link
Contributor Author

temp commented Apr 12, 2022

Since I have neither excperience with php-cs-fixer nor easy-coding-standard (we are only using phpcs), I don't know if this should be part of this PR.
Also, rector is something that's not done quickly (in our experience), so again I'm against delaying this PR for rector.
All tests are green right now, this would only artificially expand this PR.

On the other hand it would of course be great to move to easy-coding-standard and rector in the long run. Maybe this could be developed in a seperate branch?

And for PHP 8.1 - I see no reason, Symfony has 8.0+, and like I said above, all tests are green for now. But it would of course be possible.

@Spomky
Copy link
Member

Spomky commented Apr 12, 2022

Ok @temp. Thank you for your advices.

@Spomky Spomky changed the base branch from v3.0 to v4.0 April 12, 2022 11:51
@Spomky
Copy link
Member

Spomky commented Apr 12, 2022

I've just created a new branch v4.0 and merged another PR.
Let me just test it before and we are good to go.

@Spomky Spomky merged commit 5d6c815 into Spomky-Labs:v4.0 Apr 13, 2022
@Spomky
Copy link
Member

Spomky commented Apr 13, 2022

OK let's go with this new branch.
Many thanks!

@temp
Copy link
Contributor Author

temp commented Apr 13, 2022

Awesome!

@temp
Copy link
Contributor Author

temp commented Apr 13, 2022

@Spomky when will you create a release for 4.0, after your rector/ecs changes?

@Spomky
Copy link
Member

Spomky commented Apr 13, 2022

It seems to be ready now. I don't see any other modification.
Also, I created a dedicated Flex Repository and it works fine (https://github.com/Spomky-Labs/lexik-jose-bridge#symfony-flex).

@temp
Copy link
Contributor Author

temp commented Apr 14, 2022

Nice! Will try it out when a tagged release is available.

@Spomky
Copy link
Member

Spomky commented Apr 14, 2022

Tagged!
Let me know if something is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants