Skip to content

Conversation

@alexander-yevsyukov
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 20, 2026 19:57
@alexander-yevsyukov alexander-yevsyukov self-assigned this Jan 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates project documentation by replacing informal "Please note" phrases with more concise "Note that" phrasing, and bumps version numbers across multiple configuration files and documentation.

Changes:

  • Simplified documentation language by removing "Please" prefix from note statements
  • Updated version from 2.0.0-SNAPSHOT.393 to 2.0.0-SNAPSHOT.394 across configuration files
  • Updated dependency versions (CoreJvmCompiler from .050 to .051, validation-jvm-runtime from .392 to .393)

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.gradle.kts Bumped validation version to .394
tests/consumer/src/test/kotlin/io/spine/validation/test/CurrencyOptionITest.kt Removed "Please" from documentation note
pom.xml Updated project version to .394 and dependency versions
jvm-runtime/src/main/kotlin/io/spine/validation/MessageValidator.kt Simplified "Please note" to "Note" in KDoc
java/src/main/kotlin/io/spine/tools/validation/java/setonce/SetOnceEnumField.kt Condensed and simplified documentation note
java/src/main/kotlin/io/spine/tools/validation/java/setonce/SetOnceBytesField.kt Condensed and simplified documentation note
java/src/main/kotlin/io/spine/tools/validation/java/JavaValidationPlugin.kt Reformatted multi-line KDoc note for clarity
docs/01-getting-started/index.md Improved line wrapping for better readability
dependencies.md Updated version references and generation timestamps
config Updated subproject commit reference
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt Updated validation version constant to .393
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Updated CoreJvmCompiler versions to .051

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 22, 2026 20:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

docs/options.proto:1

  • Corrected spelling of 'please' to 'use' for consistency with the PR's goal of removing informal language like 'Please' from comments.
/*

docs/ToC.md:1

  • These link text entries still use title case capitalization ("First Validated Model", "Validation Workflow") while other entries in the same file have been updated to sentence case. These should be changed to "Your first validated model" and "Validation workflow" for consistency.
# Spine Validation — Table of contents

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


## What’s Next
## What's next

- [Target Audience](target-audience.md)
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text "Target Audience" uses title case, but the PR has changed the target file's heading to sentence case "Target audience". The link text should match for consistency.

Suggested change
- [Target Audience](target-audience.md)
- [Target audience](target-audience.md)

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 4, 2026 19:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 51 out of 58 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 5, 2026 18:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 61 out of 70 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported
  • docs/_preview/package-lock.json: Language not supported
Comments suppressed due to low confidence (8)

docs/gradlew.bat:1

  • This file appears to contain an absolute path to a user's local file system rather than being an actual Gradle wrapper script. Gradle wrapper files should contain the wrapper script content, not file paths. This will not work for other developers or in CI environments.
    docs/gradlew:1
  • This file appears to contain an absolute path to a user's local file system rather than being an actual Gradle wrapper script. Gradle wrapper files should contain the wrapper script content, not file paths. This will not work for other developers or in CI environments.
    docs/gradle.properties:1
  • This file contains only a relative path instead of actual Gradle properties. While this might be intended as a symbolic link reference, it won't work as a regular file. Consider either copying the properties or using Gradle's project structure to reference parent properties.
    docs/_code/first-model/gradlew.bat:1
  • This file contains an absolute path to a user's local file system rather than the actual Gradle wrapper script. This will not work for other developers or in CI environments.
    docs/_code/first-model/gradlew:1
  • This file contains an absolute path to a user's local file system rather than the actual Gradle wrapper script. This will not work for other developers or in CI environments.
    docs/_code/first-model/gradle.properties:1
  • This file contains an absolute path to a user's local file system rather than actual Gradle properties. This will not work for other developers or in CI environments.
    docs/_code/first-model/buildSrc:1
  • This file contains only an absolute path reference. buildSrc directories should contain actual build source code, not file path references. This will not work for other developers or in CI environments.
    docs/content/docs/validation/01-getting-started/first-model.md:1
  • Corrected spelling of 'simplified' - the word is correct but the pattern on line 32 appears to have an issue. The regex pattern ^\\d{4}(?: \\d{4}){3} expects exactly 4 groups of 4 digits (16 total), but the comment says 'simplified'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

(pattern).regex = "^\\d{4}(?: \\d{4}){3}"
];

// Must be present and contain at least 4 Latin letters or spaces.
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern requires at least 4 characters total ([A-Z] + at least 2 from [A-Za-z ] + [A-Za-z]), but the comment on line 23 states 'at least 4 Latin letters or spaces'. This pattern actually allows spaces to count toward the minimum, and the ending [A-Za-z] prevents names from ending with a space. The pattern doesn't precisely match the stated requirement. Consider using ^[A-Z](?:[A-Za-z] ){2,}[A-Za-z]$ if spaces between words are required, or clarify the requirements.

Suggested change
// Must be present and contain at least 4 Latin letters or spaces.
// Must be present, contain at least 4 characters, start and end with a Latin letter,
// and may contain spaces between words.

Copilot uses AI. Check for mistakes.
Also:
 * Remove (c) headers from scripts.
 * Update `GRADLE.md` to reflect path relative to the `docs` directory.
Copilot AI review requested due to automatic review settings February 5, 2026 20:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 62 out of 71 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported
  • docs/_preview/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

docs/_script/hugo-serve:1

  • Corrected spelling of '_preivew' to '_preview'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Including example sources

It is done in the [`settings.gradle.kts`](settings.gradle.kts) file via `includeBuild` directive.
If you add another example proejct, please remember to update
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'proejct' to 'project'.

Suggested change
If you add another example proejct, please remember to update
If you add another example project, please remember to update

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 9, 2026 20:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 73 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported
  • docs/_preview/package-lock.json: Language not supported
Comments suppressed due to low confidence (7)

docs/_script/hugo-serve:1

  • Directory name looks misspelled (_preivew vs _preview). This will make the script run Hugo from the wrong working directory (or fail to cd). Rename to cd _preview.
    docs/_script/hugo-serve:1
  • This script uses unquoted variable expansions and sources user-controlled shell init files. For reliability, quote variables in test/source operations (e.g., \"$BASH_PROFILE\") and consider avoiding sourcing user profiles entirely (or gating it behind an explicit flag) to keep the docs build deterministic.
    docs/_script/hugo-build:1
  • Same quoting/determinism concerns as in hugo-serve: quote variable expansions and reconsider sourcing user shell init files from build scripts to avoid environment-dependent behavior.
    docs/_script/install-dependencies:1
  • Same quoting/determinism concerns as in other scripts. Also consider adding set -e to fail fast if cd _preview or npm install fails.
    jvm-runtime/build.gradle.kts:1
  • Switching from implementation to api changes the published dependency surface of jvm-runtime (consumers now see/resolve Base.lib transitively). Unless Base.lib types are intentionally part of this module’s public API, prefer keeping it as implementation to avoid leaking internals and to reduce downstream dependency coupling.
    docs/content/docs/validation/01-getting-started/adding-to-build.md:1
  • Typo: base onbased on.
    docs/_settings/embed-code.yml:1
  • The top-level code-path/docs-path duplicates the single entry in embed-mappings with identical values. Consider keeping only one source of truth (either remove the redundant top-level keys or remove the redundant embedded mapping) to avoid future drift.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -39,4 +39,5 @@ object BuildSettings {
val javaVersionCompat = JavaVersion.toVersion(JVM_VERSION)
val jvmTarget = JvmTarget.JVM_17
const val REMOTE_DEBUG_PORT = 5566
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a magic-number timeout without context. Consider adding a short KDoc/line comment explaining what this timeout is used for, and/or naming it more specifically (e.g., DOCS_BUILD_TIMEOUT_MINUTES, CI_TASK_TIMEOUT_MINUTES) so its scope is clear.

Suggested change
const val REMOTE_DEBUG_PORT = 5566
const val REMOTE_DEBUG_PORT = 5566
/**
* Default timeout (in minutes) for long-running Gradle tasks in CI.
*/

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant