Improve dependencies management #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmdashenkov
approved these changes
Dec 7, 2020
Contributor
dmdashenkov
left a comment
dmdashenkov
left a comment
There was a problem hiding this comment.
@yuri-sergiichuk, LGTM with a few minor comments.
| NewBoundedContextBuilderTest.class.getName()); | ||
| assertFalse(builder.tenantIndex() | ||
| .isPresent()); | ||
| assertThat(builder.tenantIndex()).isEmpty(); |
Contributor
There was a problem hiding this comment.
Suggested change
| assertThat(builder.tenantIndex()).isEmpty(); | |
| assertThat(builder.tenantIndex()) | |
| .isEmpty(); |
| assertTrue(updatedIndex.isPresent()); | ||
| assertThat(updatedIndex.get(), instanceOf(TestNamespaceIndex.getType())); | ||
| assertThat(updatedIndex).isPresent(); | ||
| Truth.assertThat(updatedIndex.get()) |
Contributor
There was a problem hiding this comment.
Please use a static import. Java can handle multiple imported methods with the same name if parameters are different.
Contributor
Author
There was a problem hiding this comment.
What's interesting is that IDEA does not allow fixing if not doing the static import manually.
| .tenantIndex(); | ||
| assertTrue(updatedIndex.isPresent()); | ||
| assertThat(updatedIndex.get(), instanceOf(TestNamespaceIndex.getType())); | ||
| assertThat(updatedIndex).isPresent(); |
Contributor
There was a problem hiding this comment.
Please apply the formatting as in the suggestion above — the assertion on a new line. It's our conversion. It makes assertions easier to read.
| assertNotNull(namespace); | ||
| assertEquals(namespaceValue, namespace.value()); | ||
| assertThat(namespace).isNotNull(); | ||
| assertThat(namespace.value()).isEqualTo(namespaceValue); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our Gradle dependencies management a bit and applies the new scope to the dependencies that are used by the code analysis software only.
As part of the PR, I have also eliminated the usage of the
hamcrestassertion framework in favor oftruth.The change is related to the SpineEventEngine/config#156 issue.