Commanding methods #804
Commanding methods #804
Conversation
Also: rename `Commander` -> `AbstractCommander`
... to be inline with `SubscribingClass`.
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
============================================
+ Coverage 93.19% 93.28% +0.08%
- Complexity 3431 3548 +117
============================================
Files 437 462 +25
Lines 11629 11956 +327
Branches 697 705 +8
============================================
+ Hits 10838 11153 +315
- Misses 589 599 +10
- Partials 202 204 +2 |
Also: fix split generation, introduce abstract base for event-caused command sequence.
alexander-yevsyukov
requested review from
armiol,
mdrachuk,
vlad-lubenskyi and
dmdashenkov
|
@armiol, PTAL. @mdrachuk, @vlad-lubenskyi, @dmdashenkov, you are welcome to review and comment too. You recently updated parts of the system which this PR modifies. |
.idea/dictionaries/common.xml
Outdated
| @@ -19,7 +18,7 @@ | |||
| <w>flushables</w> | |||
| <w>googleapis</w> | |||
| <w>gradle</w> | |||
| <w>grpc</w> | |||
| <w>grpc</w> | |||
There was a problem hiding this comment.
Seems like a redundant change.
There was a problem hiding this comment.
@alexander-yevsyukov LGTM in general. Please see my comments.
| * @author Alexander Yevsyukov | ||
| */ | ||
| @Internal | ||
| public class OneCommand extends OnEvent<MarkCausedCommand, MarkCausedCommand.Builder, OneCommand> { |
There was a problem hiding this comment.
Can it be SingleCommand? I understand that's longer, but "one command" may mean a particular item from the list of items.
E.g. "I have one command that creates projects" means "I have plenty of commands, and one of them creates projects". But "I have a single command that creates project" means "There is exactly one command ...".
| * @author Alexander Yevsyukov | ||
| */ | ||
| @Immutable(containerOf = "M") | ||
| public class EventReceivingClassDelegate<T, M extends HandlerMethod<?, EventClass, ?, ?>> |
There was a problem hiding this comment.
Please document the generic parameters.
| extends ModelClass<T> { | ||
|
|
||
| private static final long serialVersionUID = 0L; | ||
| private final MessageHandlerMap<EventClass, M> events; |
There was a problem hiding this comment.
Please have an empty line above.
This PR introduces
@Commandannotation for methods that issue one or more command messages in response to incoming command or event.ProcessManagers andCommanders can have such methods.New system events and commands were introduced to update command and event lifecycle aggregates with events on emitting a command in response to incoming command/event.
Other notable changes:
of()methods ofMessageClassdescendants that accept message classes were renamed tofrom()to allow using method references together withof()which accepts message instances.CommandReceiver,EventReceiver,EventSubscriber,CommandingClass,SubscribingClass,ReactingClass, etc.SystemGateway.