Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Flexible server #1443

Merged
merged 6 commits into from
Mar 22, 2022
Merged

[1.x] Flexible server #1443

merged 6 commits into from
Mar 22, 2022

Conversation

dmdashenkov
Copy link
Contributor

This is a PR to the v1.8 branch.

In this PR we expand the io.spine.server.Server API to allow to:

  • obtain the Query, Subscription, and Command services after the Server is built;
  • add extra gRPC services to the same server.

This PR is related to #1415. That issue will be closed after the same change is done to the v2.0 branch.

@dmdashenkov dmdashenkov self-assigned this Mar 22, 2022
@dmdashenkov dmdashenkov marked this pull request as ready for review March 22, 2022 14:28
@dmdashenkov dmdashenkov requested a review from armiol March 22, 2022 14:49
@dmdashenkov
Copy link
Contributor Author

@armiol, PTAL. @dmytro-kashcheiev, FYI.

armiol
armiol approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmdashenkov dmdashenkov merged commit 718b18f into 1.x-dev Mar 22, 2022
@dmdashenkov dmdashenkov deleted the flexible-server-1.8 branch March 22, 2022 16:39
@armiol armiol changed the title Flexible server [1.x] Flexible server Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armiol armiol armiol approved these changes

Assignees

@dmdashenkov dmdashenkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmdashenkov @armiol