[1.x] Make BlackBoxContext provide a Client linked to the context under the test
#1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armiol
reviewed
Oct 25, 2021
There was a problem hiding this comment.
@yevhenii-nadtochii please see my comments. This is the first round of the review. I will need to have another look once it's ready for the final review.
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Outdated
Show resolved
Hide resolved
testutil-server/src/test/java/io/spine/testing/server/blackbox/BlackBoxContextTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 1.x-dev #1407 +/- ##
=============================================
+ Coverage 90.97% 91.00% +0.02%
- Complexity 4786 4804 +18
=============================================
Files 615 616 +1
Lines 15197 15261 +64
Branches 859 861 +2
=============================================
+ Hits 13826 13888 +62
- Misses 1100 1101 +1
- Partials 271 272 +1 |
yevhenii-nadtochii
force-pushed
the
enrich-black-box-context
branch
from
a1be142 to
cb99f49
Compare
yevhenii-nadtochii
changed the title
BlackBoxContext provide a Client linked to the context under the test
armiol
requested changes
Oct 26, 2021
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ClientProvider.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ClientProvider.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ClientProvider.java
Outdated
Show resolved
Hide resolved
…instance each time
armiol
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
@yevhenii-nadtochii LGTM with some minor comments to address before merging.
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxContext.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ClientSupplier.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ClientSupplier.java
Outdated
Show resolved
Hide resolved
yevhenii-nadtochii
changed the title
BlackBoxContext provide a Client linked to the context under the testBlackBoxContext provide a Client linked to the context under the test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientProviderthat accepts aBoundedContexton its constructor and distributesClientinstances linked to the passed context. The provider lazily creates in-processGrpcContainerfor that;BlackBoxContextprovide aClientasblackBoxContext.client().