Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async message delivery and improvements for Subscriptions #1265

Merged
merged 7 commits into from
Apr 20, 2020

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Apr 20, 2020

This PR:

  • Extends the Delivery class with the factory method for creating local Delivery which handles each message in a separate thread (by @armiol). This is needed for simulating distributed handling of messages (e.g. in example apps). The default behaviour of Delivery is synchronous.
  • Transforms Subscriptions class from being a utility into a collection of Subscriptions made by a `Client. This will simplify the management of subscriptions in a client apps.

TODOs added by this PR in the Subscriptions class for improving handling of negative Acks will be addressed shortly in following PRs.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Apr 20, 2020
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review April 20, 2020 15:25
@alexander-yevsyukov alexander-yevsyukov changed the title Async message delivery Async message delivery and improvements for Subscriptions Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1265 into master will decrease coverage by 0.02%.
The diff coverage is 94.20%.

@@             Coverage Diff              @@
##             master    #1265      +/-   ##
============================================
- Coverage     91.06%   91.03%   -0.03%     
- Complexity     4656     4665       +9     
============================================
  Files           598      597       -1     
  Lines         14767    14801      +34     
  Branches        841      843       +2     
============================================
+ Hits          13447    13474      +27     
- Misses         1057     1063       +6     
- Partials        263      264       +1     

@alexander-yevsyukov alexander-yevsyukov merged commit e854e3d into master Apr 20, 2020
@alexander-yevsyukov alexander-yevsyukov deleted the async-message-delivery branch April 20, 2020 15:54
@dmitrykuzmin dmitrykuzmin mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants