Async message delivery and improvements for Subscriptions #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Delivery
class with the factory method for creating localDelivery
which handles each message in a separate thread (by @armiol). This is needed for simulating distributed handling of messages (e.g. in example apps). The default behaviour ofDelivery
is synchronous.Subscriptions
class from being a utility into a collection ofSubscriptions
made by a `Client. This will simplify the management of subscriptions in a client apps.TODOs added by this PR in the
Subscriptions
class for improving handling of negativeAck
s will be addressed shortly in following PRs.