-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to InboxMessage
behavior
#1239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the tests overridable in order to allow their disabling.
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
============================================
- Coverage 91.22% 91.21% -0.02%
- Complexity 4726 4728 +2
============================================
Files 615 616 +1
Lines 14823 14828 +5
Branches 834 834
============================================
+ Hits 13523 13526 +3
- Misses 1044 1046 +2
Partials 256 256 |
dmdashenkov
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@armiol, LGTM with a couple of formatting comments.
Co-Authored-By: Dmytro Dashenkov <dmytro.dashenkov@teamdev.com>
Co-Authored-By: Dmytro Dashenkov <dmytro.dashenkov@teamdev.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset modifies the way we store
InboxMessage
s.InboxMessage
now has microsecond precision. On storage level, it allows using the native data types, which typically support microseconds at most.InboxMessage
now includes theShardIndex
which previously was a part ofInboxMessage
body. Such an approach allows storingInboxMessage
s as a hierarchy of objects. In turn, in Google Datastore that opens a possibility to query these messages in a transaction.Please note that existing binaries of
InboxMessage
become incompatible with this code version.So make sure to deliver or purge the existing messages of this type prior to migration.
As a minor change, the
CatchUpTest
has been made open for configuration in the dependant libraries, such asspine-gcloud-java
.The library version is updated to
1.4.9
.