Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to InboxMessage behavior #1239

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Updates to InboxMessage behavior #1239

merged 7 commits into from
Feb 27, 2020

Conversation

armiol
Copy link
Contributor

@armiol armiol commented Feb 27, 2020

This changeset modifies the way we store InboxMessages.

  • The timestamp of InboxMessage now has microsecond precision. On storage level, it allows using the native data types, which typically support microseconds at most.
  • The identifier of InboxMessage now includes the ShardIndex which previously was a part of InboxMessage body. Such an approach allows storing InboxMessages as a hierarchy of objects. In turn, in Google Datastore that opens a possibility to query these messages in a transaction.

Please note that existing binaries of InboxMessage become incompatible with this code version.
So make sure to deliver or purge the existing messages of this type prior to migration.

As a minor change, the CatchUpTest has been made open for configuration in the dependant libraries, such as spine-gcloud-java.

The library version is updated to 1.4.9.

@armiol armiol self-assigned this Feb 27, 2020
@armiol armiol changed the title Time in micros Updates to InboxMessage behavior Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #1239 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1239      +/-   ##
============================================
- Coverage     91.22%   91.21%   -0.02%     
- Complexity     4726     4728       +2     
============================================
  Files           615      616       +1     
  Lines         14823    14828       +5     
  Branches        834      834              
============================================
+ Hits          13523    13526       +3     
- Misses         1044     1046       +2     
  Partials        256      256

@armiol armiol marked this pull request as ready for review February 27, 2020 16:11
@armiol armiol requested a review from dmdashenkov February 27, 2020 16:11
Copy link
Contributor

@dmdashenkov dmdashenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armiol, LGTM with a couple of formatting comments.

armiol and others added 2 commits February 27, 2020 18:59
Co-Authored-By: Dmytro Dashenkov <dmytro.dashenkov@teamdev.com>
Co-Authored-By: Dmytro Dashenkov <dmytro.dashenkov@teamdev.com>
@armiol armiol merged commit 1a74195 into master Feb 27, 2020
@armiol armiol deleted the time-in-micros branch February 27, 2020 17:28
@armiol armiol mentioned this pull request Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants