Fix Stringifiers.toString(...) not processing enum values
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplify and rename its "enum" counterpart.
Also fixed the old doc formatting across changed files.
The conversion of `List` and `Map` by `Stringifiers.toString(...)` will remain unsupported. The conversion logic is too convoluted and includes complex type parameter resolution. Anyone trying to stringify `List` or `Map` is better off using `Stringifiers.newForListOf(...)` and `Stringifiers.newForMapOf(...)`.
|
@armiol PTAL. |
armiol
approved these changes
Aug 26, 2019
| void createListType() { | ||
| Type type = listTypeOf(String.class); | ||
| Type expectedType = new TypeToken<List<String>>(){}.getType(); | ||
| assertEquals(expectedType, type); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("tell if the type is a enum class") |
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
===========================================
+ Coverage 72.94% 73.1% +0.16%
- Complexity 2525 2535 +10
===========================================
Files 432 432
Lines 10191 10204 +13
Branches 608 610 +2
===========================================
+ Hits 7434 7460 +26
+ Misses 2587 2573 -14
- Partials 170 171 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Stringifiers.toString(...)throwing an exception on receiving anenumvalue.The
enumvalues were not supported because theEnumStringifierwas actually abstract and was intended for inheritance only. It was done so because theEnumStringifieris aSerializableStringifierand all serializable stringifiers are persisted as singletons. But it's impossible to persist an arbitrary enum stringifier as a singleton.This PR makes an
EnumStringifiera concrete class which is still aSerializableStringifierbut is not persisted as a singleton (but rather as an ordinary serializable object).