Filter files with custom options being built #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yevsyukov
changed the title
armiol
approved these changes
Jan 21, 2022
cli/src/main/kotlin/io/spine/protodata/cli/DescriptorExtensions.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue resulted in
ClassNotFoundExceptionwhen trying to load custom options form a proto file containing custom options and being built by ProtoData.Recently, instead of specifying option files, we started detecting them by the presence of extensions (
FileDescriptor.getExtensions()). It works well until we try to use ProtoData on a newly createdprotofile with custom extensions declared, but without outer class generated yet. Until this PR we attempted to load a Java class by the name corresponding to the given descriptor. Since there was no Java file produced at this stage, the attempt failed withClassNotFoundException.This PR fixes the issue by skipping the proto files without outer class already available.