Skip to content

Commit

Permalink
remove todos
Browse files Browse the repository at this point in the history
  • Loading branch information
chrieke committed Mar 24, 2022
1 parent b011436 commit 28f247b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,5 @@ Interactive installation + changes in package require app restart.

## TODO
- Cleanup examples
- svg vs png display quality?
- Nördlingen, 136 radius just plots first example, maybe if geocoding doesnt work, same with miami
- if changing example, only values that are different in example definition are reset, e.g. contour color etc.

- ValueError: Nominatim could not geocode query "matthias-ehrenfried-str. 16, 97074 wuerzburg"
- if changing example, only values that are different in example definition are reset, e.g. contour color etc.
8 changes: 4 additions & 4 deletions prettymapp/plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def plot_linestring_collection(ax, lines, linewidth_values=None, **kwargs) -> No
lines: Iterable of shapely linestrings, not MultiLinestring.
linewidth_values: Assignment of colormap, should match length of geoms.
"""
linecollection = LineCollection(lines, **kwargs) # todo: kwargs
if linewidth_values is not None: # todo values
linecollection = LineCollection(lines, **kwargs)
if linewidth_values is not None:
linecollection.set_linewidth(linewidth_values)
ax.add_collection(linecollection, autolim=True)

Expand Down Expand Up @@ -88,7 +88,7 @@ def __post_init__(self):
self.ymin,
self.xmax,
self.ymax,
) = self.aoi_bounds # TODO: dont take from totalbounds,
) = self.aoi_bounds
# take from aoi geometry bounds, otherwise if no geometries on one side problematic.
self.xmid = (self.xmin + self.xmax) / 2
self.ymid = (self.ymin + self.ymax) / 2
Expand Down Expand Up @@ -211,7 +211,7 @@ def set_map_contour(self):
self.ax.patch.set_zorder(6)

def set_background(self):
ec = adjust_lightness(self.bg_color, 0.78) # todo: correct value?
ec = adjust_lightness(self.bg_color, 0.78)
if self.bg_shape == "rectangle":
patch = Rectangle(
xy=(self.xmin - self.bg_buffer_x, self.ymin - self.bg_buffer_y),
Expand Down

0 comments on commit 28f247b

Please sign in to comment.