Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More usability improvements sw fitpowder (DRAFT IN PROG) #210

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RichardWaiteSTFC
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 62.50000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 43.36%. Comparing base (7e87dee) to head (cc82c7f).

Files with missing lines Patch % Lines
swfiles/sw_fitpowder.m 62.50% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   43.29%   43.36%   +0.07%     
==========================================
  Files         243      243              
  Lines       16383    16439      +56     
==========================================
+ Hits         7093     7129      +36     
- Misses       9290     9310      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 14, 2025

Test Results

    4 files  ± 0    124 suites  ±0   5m 29s ⏱️ - 1m 2s
  835 tests + 4    775 ✅  - 38  18 💤 ±0  2 ❌ +2  40 🔥 +40 
2 340 runs  +16  2 261 ✅  - 27  36 💤 ±0  2 ❌ +2  41 🔥 +41 

For more details on these failures and errors, see this check.

Results for commit cc82c7f. ± Comparison against base commit 7e87dee.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.
sw_tests.unit_tests.unittest_sw_fitpowder ‑ test_set_background_strategy
sw_tests.unit_tests.unittest_sw_fitpowder ‑ test_fit_background_and_scale
sw_tests.unit_tests.unittest_sw_fitpowder ‑ test_set_background_strategy_to_indep
sw_tests.unit_tests.unittest_sw_fitpowder ‑ test_set_background_strategy_to_planar
sw_tests.unit_tests.unittest_sw_fitpowder ‑ test_set_bg_region_data_1d
sw_tests.unit_tests.unittest_sw_fitpowder ‑ test_set_bg_region_data_2d

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants