Warn about non-mergeable units instead of raising an error #4219
+43
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
added
core
Member
|
I think the raise was good. |
Member
Author
|
Ok I'll add an option, then we'll debate the default. |
chrishalcrow
commented
Dec 2, 2025
alejoe91
approved these changes
Dec 3, 2025
alejoe91
reviewed
Dec 3, 2025
alejoe91
reviewed
Dec 3, 2025
alejoe91
reviewed
Dec 3, 2025
alejoe91
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly changes the merging logic. It checks to see which units are mergeable (wrt to the sparsity threshold) before trying to merge.
Now we warn and don't merge the units, rather than error the entire process, if individual units cannot be merged.
I tried implementing this inside of
_save_or_select_or_merge_or_splitbut it was a mess. I think it's best to know your new unit ids and final merge groups before this function is called.@samuelgarcia @yger feedback welcome! I need to add some tests...