Fix bug in waveform generation + adapt parameters #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
approved these changes
Oct 10, 2025
…keinterface into generation_ajust_params
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…keinterface into generation_ajust_params
|
@yger @alejoe91 @chrishalcrow : this is ready to merge on my side. |
| # TODO: Need a better & faster way than this. | ||
| min_diff = np.min(np.abs(injected_spike_train[:, None] - spike_train[None, :]), axis=1) | ||
| violations = min_diff < t_r | ||
| injected_spike_train = injected_spike_train[~violations] |
There was a problem hiding this comment.
In line 285 (10 lines above!) should np.random.uniform be seeded? Or just a rng?
|
IGNORE ME
|
|
Tests are passing. I merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a bug in how we do the generation the spattial waveform when it is an ellispoid.
It bug had an impact on the waveform amplitude itself.
The new way is a bit more simple but less buggy with no border effect on amplitude.
This also change the parameters range and names to avoid confusion.
Additionally it remove all the
np.random.randnp.random.randnnp.rand.choiceand use explicit randome generator with clear seed.