-
Notifications
You must be signed in to change notification settings - Fork 221
Update/Fix for MaxWell systems #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Extract stimulation and Maxwell spike events
Remove duplicate channel_id assignments (preferentially keep earlier ids)
Removed duplicate removal temporarily
Remove 1) instances where multiple MaxWell electrodes are connected to the same channel (mix of electrode signals) and 2) duplicates where multiple MaxWell channels and connected to the same electrode (duplicates).
Significant update for MaxWell systems - now utilize events to extract MAXWELL SPIKE (via built in template matching) and STIMULATION events.
for more information, see https://pre-commit.ci
Avoids using pandas and fixed error with pop use
for more information, see https://pre-commit.ci
Updated main
@cmccrimmon all tests fail, and I think it's because of the changes to neobase. Can you double check? For the Maxwell part, @philipp-mxw can you review? |
When using the h5 file provided in one of the associated issues, it fails for me already before any of the changes are actually run
|
Updated for current MaxWell systems - now utilize events to extract MAXWELL SPIKE (via built in template matching) and STIMULATION events. Also remove 1) instances where multiple MaxWell electrodes are connected to the same channel (mix of electrode signals) and 2) duplicates where multiple MaxWell channels and connected to the same electrode (duplicates) as discussed in NeuralEnsemble/python-neo#1703. Updated prior closed pull request #4015 to avoid pandas usage.