-
Notifications
You must be signed in to change notification settings - Fork 216
keep probe_planar_contour when aggregating channels #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Hello, looking great - good bug catch! There are other annotations we're not forwarding during this function (like
I think the hard thing is to make the all( np.all(k == first_annotation_value) for k in annotation_values)) seems ok, but maybe someone has a better idea. |
Thanks for this. |
@chrishalcrow I think your idea will work well with small modifications from what I proposed. I won´t have time to test this this week though! |
I would like to point out that this is a data point of just passing the whole probe as an attribute and fetch the information from the probe when it is available. Spreading the probe information across annotations and properties makes this type of error harder to trace. |
Fix #3947