-
Notifications
You must be signed in to change notification settings - Fork 216
Add splitting functionality to curation and SortingAnalyzer
#3817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e into curation-pydantic
…e into curation-pydantic
old_template = arr[self.sorting_analyzer.sorting.ids_to_indices([split_unit_id])[0], ...] | ||
new_indices = np.array([new_unit_ids.index(unit_id) for unit_id in new_splits]) | ||
new_array[new_indices, ...] = np.tile(old_template, (len(new_splits), 1, 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelgarcia this needs to be discussed. What should we do if the waveforms
extension is not there? The current behavior is copying, but we mught want to force recompute here
This is amazing camarade. I would do first a PR to focus only on the format. And then merge this one. |
I did camarade! #3760 |
Depends on #3760
Implements splitting functionality in:
sorting_tools
:apply_splits_to_sorting
SortingAnalyzer
:.split_units()
AnalyzerExtension
:_split_extension_data
(implemented function for all extensions and extended tests)