Skip to content

Add tests for windows and mac #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
Jun 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
b2164c9
great tests, good tests, the end of all test
h-mayorquin May 30, 2024
0d9536c
modify installation
h-mayorquin May 30, 2024
0741622
bash shell
h-mayorquin May 30, 2024
b97a079
eliminate mistake
h-mayorquin May 30, 2024
5ecf387
no need to prune when dealing with latest version
h-mayorquin May 30, 2024
28fea4b
no need for source environment
h-mayorquin May 30, 2024
2cf7668
no code coverage on this one
h-mayorquin May 30, 2024
16f6a5b
Merge branch 'main' into add_tests_for_all_os
h-mayorquin May 30, 2024
7a09691
added mac import fail quick
h-mayorquin May 30, 2024
e09aa61
add caching remove ubuntu
h-mayorquin May 31, 2024
89bc0d2
wrong type of cachcing, dumb mistake of mine
h-mayorquin May 31, 2024
37d93e1
correct command
h-mayorquin May 31, 2024
07460f6
separate test by module
h-mayorquin May 31, 2024
4e44122
permission for execution
h-mayorquin May 31, 2024
020551c
reduced testing
h-mayorquin May 31, 2024
1cc2bcb
forgot to avoid virtual env in core
h-mayorquin May 31, 2024
9982cfd
see origin of failure on windows
h-mayorquin May 31, 2024
1bd56e5
not fail fast to see windows mistery
h-mayorquin May 31, 2024
4b3e0a5
maybe shell issue on windows
h-mayorquin May 31, 2024
52be743
maybe shell issue on windows
h-mayorquin May 31, 2024
bf5c71e
fix windows collection by marker
h-mayorquin May 31, 2024
375e3d5
dumb marker error name
h-mayorquin May 31, 2024
282752b
faster to test mark collection this way
h-mayorquin May 31, 2024
fa7d9e8
fix mac test, enable the rest of tests
h-mayorquin May 31, 2024
1a544f8
equal assertion
h-mayorquin May 31, 2024
1e54a4b
sorter test
h-mayorquin May 31, 2024
8ed375f
try skipping core sorters
h-mayorquin May 31, 2024
e809edb
internal sorters is also failing
h-mayorquin Jun 1, 2024
f0e4c5c
restore core tests
h-mayorquin Jun 1, 2024
e56f2f0
restore conftest and container tools
h-mayorquin Jun 1, 2024
ed9ef1c
markers on widows not yet fixed
h-mayorquin Jun 1, 2024
7fb65c2
remove numba type signature (#2932)
zm711 May 30, 2024
d079d8a
fix marker collection to work on windows
h-mayorquin May 31, 2024
48f9fdb
easier fix that I do not like
h-mayorquin May 31, 2024
37ac47e
conftest fix
h-mayorquin May 31, 2024
7fd7b39
fix tee
h-mayorquin May 31, 2024
881d381
fix testing imports
h-mayorquin May 31, 2024
be00e9e
bunch of other imports
h-mayorquin May 31, 2024
8d80a6e
way more mport fixes
h-mayorquin May 31, 2024
251cd2d
even more removals
h-mayorquin May 31, 2024
7dda8c0
remove more imports
h-mayorquin May 31, 2024
701402f
even more removals
h-mayorquin May 31, 2024
d78c9c8
remove even more imports
h-mayorquin May 31, 2024
2fa06f3
remove even more imports
h-mayorquin May 31, 2024
15037b0
more pylab imports to the dustbin
h-mayorquin May 31, 2024
58a4ac0
more matplotlib terrible things]
h-mayorquin May 31, 2024
e366a45
isocut requires numba
h-mayorquin May 31, 2024
0fd14c4
more pandas and matplotlib
h-mayorquin May 31, 2024
ac6fa5a
more imports
h-mayorquin May 31, 2024
b394de1
truncated sv on clustering circus
h-mayorquin May 31, 2024
c08ff54
triage imports
h-mayorquin May 31, 2024
25a950e
more matplotlib
h-mayorquin May 31, 2024
6af7680
fix imports
h-mayorquin May 31, 2024
0b89fd7
restore nwb issue
h-mayorquin May 31, 2024
d845d23
Remove mearec from testing functions (#2930)
chrishalcrow May 31, 2024
8af34b7
missing scipy import
h-mayorquin May 31, 2024
2bdfe68
fix scipy import0
h-mayorquin May 31, 2024
2aa27c2
fix import error
h-mayorquin May 31, 2024
34c57c5
missing signal import
h-mayorquin May 31, 2024
c66f7d6
merge marker fix
h-mayorquin Jun 1, 2024
8a5366f
dumb comment that I left
h-mayorquin Jun 1, 2024
78edfb4
Merge branch 'main' into add_tests_for_all_os
h-mayorquin Jun 1, 2024
a7417bb
try extractors
h-mayorquin Jun 1, 2024
aef1e96
Merge remote-tracking branch 'refs/remotes/origin/add_tests_for_all_o…
h-mayorquin Jun 1, 2024
8e36972
try running only datalad check
h-mayorquin Jun 6, 2024
77d6e16
work in progress
h-mayorquin Jun 6, 2024
89c0e57
now working
h-mayorquin Jun 13, 2024
5ea1141
Merge branch 'main' into try_poo_instead_of_datalad
h-mayorquin Jun 13, 2024
f139f32
enable hashing
h-mayorquin Jun 14, 2024
0199677
Merge branch 'try_poo_instead_of_datalad' into add_tests_for_all_os
h-mayorquin Jun 14, 2024
b24a2b8
enable pooch for testing windows
h-mayorquin Jun 14, 2024
fda504a
windows posix fix
h-mayorquin Jun 14, 2024
238239c
add linux to tests
h-mayorquin Jun 14, 2024
29a2da9
plexon has a bug
h-mayorquin Jun 14, 2024
837eb85
internal sorters passing on windows
h-mayorquin Jun 14, 2024
a6a0e6e
skip bad test on windows
h-mayorquin Jun 14, 2024
73410f0
both sorter tests now passing
h-mayorquin Jun 14, 2024
594da45
skip plexon sorting test
h-mayorquin Jun 14, 2024
08dd62a
test simple datalad installation
h-mayorquin Jun 14, 2024
6f4e06a
Merge branch 'main' into add_tests_for_all_os
h-mayorquin Jun 14, 2024
b9d92f9
use catch for 500 errors simplify datalad instaltion even further
h-mayorquin Jun 14, 2024
f641872
restore editable install
h-mayorquin Jun 14, 2024
62286e7
add caching
h-mayorquin Jun 14, 2024
1725190
temporarily generation is not working, my fault
h-mayorquin Jun 14, 2024
2e3cb1c
improve hashing
h-mayorquin Jun 14, 2024
844c65d
Merge branch 'main' into add_tests_for_all_os
h-mayorquin Jun 18, 2024
8b3f4e4
Merge branch 'main' into add_tests_for_all_os
h-mayorquin Jun 19, 2024
b71bbd8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 19, 2024
34c0f8e
Update src/spikeinterface/extractors/tests/test_datalad_downloading.py
h-mayorquin Jun 19, 2024
5441ff4
Update src/spikeinterface/core/datasets.py
h-mayorquin Jun 19, 2024
2494c27
forgotten bash
h-mayorquin Jun 24, 2024
4905a0b
lower and higher versions
h-mayorquin Jun 25, 2024
bad309d
use restore to only restore the caches
h-mayorquin Jun 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
forgot to avoid virtual env in core
  • Loading branch information
h-mayorquin committed May 31, 2024
commit 1cc2bcbb1766f5b843dba6a3906cd1cf01e59fdd
2 changes: 1 addition & 1 deletion .github/workflows/all-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
run: chmod +x .github/run_tests.sh
shell: bash
- name: Test core
run: ./.github/run_tests.sh core
run: ./.github/run_tests.sh core --no-virtual-env
shell: bash
- name: Test extractors
env:
Expand Down