Add note about recommendation not to change batch size in Kilosort1-3 #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zm711 this should be fixed in the new images, but I'm fine leaving the warning there :) |
|
I think in the past for some issues people have suggested (here and on the KS repo) to change the batch size to help with something (maybe the eigenvector issue) so I think the warning serves the purpose of also saying that hacking solutions for that may introduce other bugs. That being said warning or not is actually fine by me. :) |
alejoe91
approved these changes
Mar 13, 2024
alejoe91
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the KS readme here. It is not advised for users to change the batch size
NT. This just adds a note saying that the SpikeInterface default is the KS recommended value as long as the user doesn't change the ntbuff either. Related to #2562.