Skip to content

get_chunk_with_margin() should accept return_scaled #2387

Open
@yger

Description

@yger

As mentionned in #2346, there is slight problem with the sortingcomponents. Currently, because of the internal function get_chunk_with_margin that do not accept return_scaled, all internal operations are performed under the hood on raw data (no scaling). This is quite often not a major issue, but if some fileformat have a negative gain, then the peaks are all upside down internally for the components. We could simply extend this function (and therefore all the node_pipelines) to accept a return_scaled argument, and leave it as default to True, as much as possible?

Metadata

Metadata

Labels

bugSomething isn't workingenhancementNew feature or requestsortingcomponentsRelated to sortingcomponents module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions