Skip to content

Creation of a FeaturesNode ? #2211

Open
@yger

Description

@yger

Actually, I think there is currently a lack of inheritance in the pipeline nodes, such that for node extracting features (Amplitudes, PtP, ....), it is currently impossible to automatically know if they are dealing with sparse or dense waveforms.

In theory, one would like to have a node (I call it FeaturesNode, same as WaveformsNode) but it could be different, that will handle this inheritance, and know what is the radius/spatial information for the waveforms. If we had such a node, then all downstream nodes (such as the Features, or even the localization nodes) could then automatically guess the radius (if any), and make internal computation accordingly. This is something I started to discuss with Sam, but as said, there is a clear need for a way to automatically let downstream nodes if they are dealing with Sparse or Dense waveforms, to have a proper representation of the spatial information

In addition, but this is a detail, I find that if we have names such as PeakSource/PeakRetriever, we should have SparseWaveformsSource of DenseWaveformsSource to be consistent, don't you think?

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions