Do not fill in LogRecord caller data by default in slf4j wrapper #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But Bungeecord doesn't even use slf4j by itself, only plugins can log things to it in the first place |
|
I meant that eventual plugins or libs using slf4j logging which we bridge to java Loggers dont fill LogRecords with data which is not used by bungee's loggers in the end. |
|
Great work, I wrote my own logger impl but this should make BungeeCords slf4j more usable. |
md-5
reviewed
Jul 3, 2021
Janmm14
force-pushed
the
slf4j-no-caller-data-by-default
branch
2 times, most recently
from
71bc871 to
89368e2
Compare
Janmm14
force-pushed
the
slf4j-no-caller-data-by-default
branch
from
89368e2 to
910a7f1
Compare
|
@md-5 So this self-assign means that you are going to change some stuff and then handle this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am no expert with slf4j/java1.4 logging framework, but as bungeecord by default does not use the caller data, it should be safe to not fill it in by default.
Added system property
net.md_5.bungee.slf4j-caller-datato restore current behaviour in case custom logging requires caller data.Should slightly improve performance of bungeecord.
Closes #3112