feat: replace HMAC with Poly1305 for performance#6
Closed
Spider4Tech wants to merge 3 commits intotest-speedfrom
Closed
feat: replace HMAC with Poly1305 for performance#6Spider4Tech wants to merge 3 commits intotest-speedfrom
Spider4Tech wants to merge 3 commits intotest-speedfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces HMAC-SHA256 with Poly1305 for message authentication, significantly improving performance while maintaining strong security guarantees.
Changes
hmacdependency and all HMAC-related code.poly1305crate for fast, constant-time message authentication.encrypt3_finalanddecrypt3_finalto use Poly1305 instead of HMAC.derive_poly1305_key_final,compute_poly1305,verify_poly1305.Cargo.tomlto reflect the new dependency.Performance Impact
Security Notes
poly1305crate, which is constant-time and audited.Testing
Migration
References
Review and feedback welcome!