Skip to content

Expose skill effect in skillStart trigger #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtwango wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Expose skill effect in skillStart trigger #1555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac73d83
Expose local.effect for skills in skillStart trigger
mtwango Feb 16, 2026
9a7f320
Changelog
mtwango Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4094,3 +4094,6 @@ When setting a property like MORE to the a spell or skill defname, trying to rea
4-12-2025, Nolok
- Fixed: Malformed spell flags being returned via scripts.
- Fixed: REGION ISEVENT didn't (always?) find REGIONTYPES.

23-02-2026, Mulambo
- Added: Exposed skill effect (local.effect, I/O) in @start and @skillStart triggers (usable for changing the value with some formula, rather than range / flat value from skill effect property.
2 changes: 2 additions & 0 deletions src/game/chars/CCharSkill.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4474,6 +4474,7 @@ bool CChar::Skill_Start( SKILL_TYPE skill, int iDifficultyIncrease )
CScriptTriggerArgsPtr pScriptArgs = CScriptParserBufs::GetCScriptTriggerArgsPtr();
pScriptArgs->m_iN1 = skill;
pScriptArgs->m_iN2 = iWaitTime;
pScriptArgs->m_VarsLocal.SetNum("Effect", m_Act_Effect);
pScriptArgs->m_VarsLocal.SetNumNew("Sound", sound);
pScriptArgs->m_VarsLocal.SetNumNew("Anim", anim);
// Execute the @START trigger and pass various craft parameters there
Expand Down Expand Up @@ -4522,6 +4523,7 @@ bool CChar::Skill_Start( SKILL_TYPE skill, int iDifficultyIncrease )
anim = (ANIM_TYPE)(pScriptArgs->m_VarsLocal.GetKeyNum("Anim"));
}
iWaitTime = (int)pScriptArgs->m_iN2;
m_Act_Effect = static_cast<int>(pScriptArgs->m_VarsLocal.GetKeyNum("Effect"));
if (IsSkillBase(skill) && iWaitTime > 0)
SetTimeoutD(iWaitTime); // How long before complete skill.

Expand Down