Skip to content

OF_PetBehaviorOwnerNeutral - missing code #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GladieUO
Copy link
Contributor

@GladieUO GladieUO commented May 4, 2025

During merge, the code got probably lost.
PR #1319
fc6c6cd

During merge, the code got probably lost
@cbnolok
Copy link
Contributor

cbnolok commented May 5, 2025

Yes, but shouldn't it be
if (IsSetOF(OF_PetBehaviorOwnerNeutral) && NPC_IsOwnedBy(pCharViewer, false)) // All pets are neutral to their owners.?
Without the !

@GladieUO
Copy link
Contributor Author

GladieUO commented May 5, 2025

Yes, but shouldn't it be if (IsSetOF(OF_PetBehaviorOwnerNeutral) && NPC_IsOwnedBy(pCharViewer, false)) // All pets are neutral to their owners.? Without the !

I dont think it should. We would have to then specify what notoriety to change to, and then else to the neutral notoriety. This way we have false only in case of flag disabled or viewer not owner.

If flag is not enabled, and viewer is owner -> show notoriety neutral
If flag is enabled, and viewer is owner -> show real notoriety
If viewer is not owner -> show real notoriety

@cbnolok
Copy link
Contributor

cbnolok commented May 5, 2025

You're right!

@cbnolok cbnolok merged commit 79378c1 into Sphereserver:dev May 5, 2025
18 checks passed
@GladieUO GladieUO deleted the OF_PetBehaviorOwnerNeutral-missing-code branch May 5, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants