Items are out of containers boundaries when dropping them into a container

[a1exp]

This is not reroducible with Orion (I guess it has additional client-side checks), but reprodicible with the default client.

First issue.
When you drop an item to a bag (just drop on a bag witout opening a bag), or create an item inside container (e.g. add gold to player with gold += 5000000 and check gold piles in the bank). Items may be out of container boundaries. See screenshot.

Second issue.
If you update TDATA3 and TDATA4 of containers then creating items via scripts (e.g. same test with gold += 5000000) will always place items at minX,minY. Seems like GetRandContainerLoc() is not called in such cases.

I fuess this function is bugged

Source-X/src/game/items/CItemContainer.cpp

Line 507 in 12224ee

void CItemContainer::ContentAdd( CItem *pItem, CPointMap pt, bool bForceNoStack, uchar gridIndex )

since it only calls GetRandContainerLoc() when initial coordinates are invalid (e.g. = 0 which is the case for TDATA3 and TDATA4 not initialized).

Fixing the first issue is more important, imo.

[a1exp]

The seconds issue is pretty straight forward and is caused by this:

Source-X/src/game/items/CItemContainer.cpp

Lines 556 to 563 in 12224ee

	if (pt.m_x < tmp_MinX)
	pt.m_x = tmp_MinX;
	if (pt.m_x > tmp_MaxX)
	pt.m_x = tmp_MaxX;
	if (pt.m_y < tmp_MinY)
	pt.m_y = tmp_MinY;
	if (pt.m_y > tmp_MaxY)
	pt.m_y = tmp_MaxY;

While the first issue is more complicated.

1. If you place an item into container like I described above, then initial point is -1,-1. So this case is triggered and GetRandContainerLoc() is called.
2. I used debug build to see what's wrong with GetRandContainerLoc(). This item (see screenshop below) was placed with p = 150,108, which is within boundaries of gump size defined here.
   

This means gump size coordinates do not correspond to x,y set by

Source-X/src/game/CObjBaseTemplate.cpp

Lines 66 to 73 in 3dbb447

	void CObjBaseTemplate::SetContainedPoint( const CPointMap & pt ) noexcept
	{
	SetUIDContainerFlags(UID_O_CONTAINED);
	m_pt.m_x = pt.m_x;
	m_pt.m_y = pt.m_y;
	m_pt.m_z = LAYER_NONE;
	m_pt.m_map = 0;
	}

.

[a1exp]

Perhaps this is the cause of the first issue, I don't understand the logic here.

Source-X/src/game/items/CItemContainer.cpp

Lines 500 to 504 in f24687c

	const int iRandOnce = (int)Calc_GetRandVal(UINT16_MAX);
	return {
	(short)(sm_ContSize[i].m_minx + (iRandOnce % (sm_ContSize[i].m_maxx - sm_ContSize[i].m_minx))),
	(short)(sm_ContSize[i].m_miny + (iRandOnce % (sm_ContSize[i].m_maxy - sm_ContSize[i].m_miny))),
	0 };

Or it may simply be the case when this struct is not filled right. E.g. if you check item's p.x and p.y in the game for a metal chest gump, the min X and Y seems to be ok, but max X and Y are in reality much less than defined here.

Source-X/src/game/items/CItemContainer.cpp

Line 385 in f24687c

{ GUMP_CHEST_METAL, 18, 105, 162, 178 },

[mtwango]

The second part is fixed on dev branch.

The first part can be fixed by defining tdata3/4 on containers. The boundaries by default are greater than the actual container gump and the positions are handled by client. If you define the boudaries with tdata3/4, it will not allow client to drop it outside of the area and it will bounce it where it can be,