Critical during summoning creatures without OFPetSlots

[mtwango]

Clean scripts and sphere, dev build 3995, OF_PetSlots in ini disabled. Add spellbook, reagents and try to summon something.

08:46:CRITICAL:Assert severity=2: 'FollowersUpdate(pChar, pChar->GetFollowerSlots(), true)' file 'D:\a\Source-X\Source-X\src\game\chars\CCharSpell.cpp', line 353, in ExcType=CAssert catched in CChar::Skill_Stage()
08:46:DEBUG:Printing STACK TRACE for debugging purposes.
08:46:DEBUG: ______ thread (id) name _____ |   # | _____________ function _____________ |
08:46:DEBUG:(662c)          T_Main |   0 |                      CWorld::_OnTick | 
08:46:DEBUG:(662c)          T_Main |   1 |                   CWorldTicker::Tick | 
08:46:DEBUG:(662c)          T_Main |   2 |                       CChar::_OnTick | 
08:46:DEBUG:(662c)          T_Main |   3 |                    CChar::Skill_Done | <-- exception catch point
08:46:DEBUG:(662c)          T_Main |   4 |                  CChar::Skill_Magery | 
08:46:DEBUG:(662c)          T_Main |   5 |                CChar::Spell_CastDone | 
08:46:DEBUG:(662c)          T_Main |   6 |            CChar::Spell_Summon_Place | <-- last function call (stack unwinding began here)

I gues this assert:

Source-X/src/game/chars/CCharSpell.cpp

Line 353 in f061c26

ASSERT(FollowersUpdate(pChar, pChar->GetFollowerSlots(), true));

should be behind if (IsSetOF(OF_PetSlots)) {} condition.

[cbnolok]

Dunno why it's inside an assert, but it shouldn't, because asserts are turned off in release builds. It's better to store the result in a temp variable and then assert its value. Then, use UnreferencedParameter on that, so that release builds won't fail because of the warning about the unused variable