Expected a valid resource. Ignoring it/Converting it to an empty one.

[mtwango]

Can we get some notion, what IDs or objects is this related to? The error comes from CResourceHolder::ResourceGetName

[cbnolok]

There are some item types that expect the MORE/MORE2 to be a valid Sphere resource (ITEMDEF, CHARDEF, etc, but generally speaking even spawn groups, AREADEF, TYPEDEF, TELEPORTS etc are resources).
When you set MORE to a resource defname or directly its UID, Sphere, finding that this is a (valid) resource, sets dword UID which is the one you can get/show in game and via scripts, but internally the flag UID_F_RESOURCE is added. That one never leaves the "core".
When you call that method, Sphere tries to look up the resource in its "registries" and when doing so it might notice that the internal dword doesn't have the UID_F_RESOURCE flag, possibly because you set MORE1 to a custom number or MORE1H to a value bigger than the one you found in the other issue, because it uses the space reserved for its internal flags. So, for that one, we need to think about a solution because it's not that straightforward

[mtwango]

Yeah, that is ok and completely understandable. Would be nice to have serial (uid) of object that this error relates to.
I spotted it during worldsave, but no line number or uid / type / def of object this error comes from is visible.

[cbnolok]

Usually, the script/savefile context is automatically catched and added to the log message, but i remember that one not always happening, thus i get it's difficult to get which item is giving headaches. Could you set a debug breakpoint to that message and check when is it called? Maybe we can find what's the events chain that leads to the script context not being catched

[mtwango]

Tested it a bit and found the issue. I think this can bassicaly happen only in 3 places. when more1 is wrong on food or (rock/grass/water) type (CItem::r_WriteMore1, case IT_FOOD; case IT_WATER:) or or more2 is wrong on crops / foliage type (CItem::r_WriteMore2, case IT_FOLIAGE).

My issue was with the food. Item from save bellow:

[WORLDITEM i_icon_horse_brown]
SERIAL=04016ea4c
NAME=Chocolate Mustang
COLOR=01bb
TYPE=t_food
ATTR=08
MORE1=01121
MORE2=017750e
CONT=0401013ad
P=18,108
CONTGRID=17

After saving:

MORE1=00
MORE2=08077750e

Values are not that much of a problem, but finding what was wrong. Maybe sending GetUID().GetObjUID() to ResourceGetName so it could be printed in error?

[cbnolok]

Try now, the log message should be useful enough