Set SPECTRAL_DSN environment from JS instead of end-user workflow file#12
Merged
guylev008 merged 9 commits intoSpectralOps:mainfrom Jun 14, 2023
chkp-jrosenboom:easier-env
Merged
Set SPECTRAL_DSN environment from JS instead of end-user workflow file#12guylev008 merged 9 commits intoSpectralOps:mainfrom chkp-jrosenboom:easier-env
guylev008 merged 9 commits intoSpectralOps:mainfrom
chkp-jrosenboom:easier-env
Conversation
Contributor
Author
|
This PR requires a new tag 'v4' to be created after merging. |
guylev008
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action originally suggests that the user should first set SPECTRAL_DSN from GitHub Secrets, then pass this environment variable as an input to the action.
If the user skips configuring the environment variable in their workflow file, and passes the input directly to the action, the installation will succeed because it uses the value read from
inputs.spectral-dsnhere.The execution of the scan itself does not use the same value, and depends on SPECTRAL_DSN being set as an environment variable. Because of this, the scan fails in this scenario:
This PR
It removes the need for the user to provide SPECTRAL_DSN both as an input to the action and as an environment variable.