BED-10006: Role type property to support edge composition queries

[MichaelGrafnetter]

Built-in Okta_Role nodes now carry a type property holding the unscoped Okta role identifier (e.g. SUPER_ADMIN, APP_ADMIN). The node id stays domain-qualified (SUPER_ADMIN@contoso.okta.com), so the new property lets queries match a role by type without parsing the id.

Summary by CodeRabbit

• Improvements
  • Built-in role records now include the role type, such as APP_ADMIN.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: d1f3f484-1d5e-46f4-ac22-a5e5a5f07352

---

📥 Commits

Reviewing files that changed from the base of the PR and between ac30ed1 and 4960ae7.

---

📒 Files selected for processing (2)

• src/openhound_okta/models/built_in_role.py
• tests/test_built_in_role_parity.py

---

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

---

---

Walkthrough

Built-in role nodes now include the role’s type in their properties. The parity test asserts the type value and retains the same expected CONTAINS edge endpoint.

Changes

Built-In Role Type

Layer / File(s)	Summary
Add role type to node properties src/openhound_okta/models/built_in_role.py, tests/test_built_in_role_parity.py	BuiltInRoleProperties now requires a string type. BuiltInRole.as_node() supplies the role type, and the parity test checks that the node has type "APP_ADMIN". The edge endpoint assertion is reformatted without changing its expected value.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 4960a

The change adds the unscoped role type while preserving the domain-qualified edge endpoint. No merge-blocking risk is identified in the supplied context.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: adding a role type property to support edge composition queries.

---

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

---

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{A rabbit checks the role type field
And sees the node’s new value revealed
The edge endpoint stays the same
The test records the type by name
Then hops away through clover green}

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot review overview

🟢 Approval recommended

The implementation is focused, consistent with existing node properties, and adequately tested.

Review effort: Balanced
Findings: None

What changed in this PR

Adds an unscoped role type property to built-in Okta role nodes while preserving domain-qualified IDs.

Changes:

• Emits the source role identifier as properties.type.
• Adds parity coverage for the new property.

File	Description
src/​openhound_okta/​models/​built_in_role.py	Defines and populates the role type property.
tests/​test_built_in_role_parity.py	Verifies the emitted type value.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[JimSycurity]

The code change is solid. There ought to be a reference in the PR to the Jira ticket (BED-????) this resolves.