Skip to content

Fix error in target plotting code #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaseeverett merged 1 commit into from
Oct 31, 2025
Merged

Fix error in target plotting code #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions R/splnr_featureRep.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ splnr_plot_featureRep <- function(df,
}


if (max(df$relative_held, na.rm = TRUE) < 1) { # Check max before multiplying
if (max(df$relative_held, na.rm = TRUE) <= 1) { # Check max before multiplying
df <- df %>%
dplyr::mutate(
relative_held = .data$relative_held * 100,
Expand Down Expand Up @@ -585,10 +585,11 @@ splnr_plot_featureRep <- function(df,
),
na.rm = TRUE
) +
ggplot2::geom_bar(
ggplot2::geom_bar( # Add features in the df that had a zero or missing target
data = df %>% dplyr::mutate(relative_held = dplyr::if_else(.data$incidental == FALSE, NA_real_, .data$relative_held)), # Use NA_real_
stat = "identity", position = "identity",
ggplot2::aes(x = .data$feature, y = .data$relative_held), na.rm = TRUE, fill = "NA", colour = "black"
ggplot2::aes(x = .data$feature, y = .data$relative_held), na.rm = TRUE,
fill = "NA", colour = "black"
) +
ggplot2::labs(title = plotTitle, x = "Feature", y = "Representation of features \nin total selected area (%)") +
ggplot2::theme_bw() +
Expand Down
Loading