Skip to content

Experience in Installation of Elia Traore (Athenizer Review)

Jump to bottom
Elia Traore edited this page Jul 3, 2017 · 1 revision

The installation was fairly easy, and after reading some of the wiki the usage was pretty straight forward.

I don't have anything bad to say about the product, but I have couple of improvement suggestions -

  • Change the button icons (maybe negative picture of spartanizer icon for the athneizer icon?) OR add descriptive tips when hovering over the icons - In first use, it's hard to understand what you should press and why
  • Explain better what's unique about your pull and push buttons in the gits - does your push also spartnize the code? does you pull athneize your code? if not, why use them over eclipse's built in git support?
  • Support using the athneizer on the method your cursor is currently in, without needing to mark the method body
  • Merge the tip that addes brackets with the following tip, instead of having it as a stand alone:
//original code
return flag? getValue() : flag2? : getValue2() : getValue3();

//1st iteration
if(flag)
    return getValue();
return flag2? : getValue2() : getValue3();

//2nd iteration
if(flag){
    return getValue();
}
return flag2? : getValue2() : getValue3();

//3rd iteration
if(flag){
    return getValue();
}
if(flag2) 
    return getValue2();
return getValue3();

you can see in this example that the 2nd iteration doesn't improve readability - you could just skip to the 3rd one.

  • Limit the amount of times the athneizer can be activated - I've found a bug when trying to activate it too many times, causing the generated code to not compile, I've opened an issue about this bug: #1602 bug_atanizer

Other then that, great project! Thanks for letting me review it 😄

Clone this wiki locally