Skip to content

SpGeMM #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 5, 2023
Merged

SpGeMM #77

merged 18 commits into from
May 5, 2023

Conversation

IgorErin
Copy link
Contributor

@IgorErin IgorErin commented May 3, 2023

Proposed Changes

  • CUSP-like SpGeMM

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to GraphBLAS-sharp?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@IgorErin IgorErin requested a review from gsvgit May 4, 2023 12:45
@@ -37,7 +37,7 @@ module Generators =

let genericSparseGenerator zero valuesGen handler =
let maxSparsity = 100
let sparsityGen = Gen.choose (0, maxSparsity)
let sparsityGen = Gen.choose (1, 10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why maxSparsity replaced with constant?

@@ -69,13 +69,8 @@ let makeTest isEqual zero createMatrix (array: 'a [,]) =

let expectedColumns, expectedRows, expectedValues =
array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the name of the file is Froma...

@IgorErin IgorErin requested a review from gsvgit May 5, 2023 12:15
@gsvgit gsvgit merged commit e1a9e5b into SparseLinearAlgebra:dev May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants