Spgemm #72
Merged
Spgemm #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorErin
commented
Apr 7, 2023
|
|
||
| let getUniqueBitmapLastOccurrence clContext = | ||
| getUniqueBitmapGeneral | ||
| <| <@ fun (gid: int) (length: int) (inputArray: ClArray<'a>) -> |
There was a problem hiding this comment.
Code duplication with this
gsvgit
reviewed
Apr 8, 2023
| else | ||
| isUniqueBitmap.[i] <- 1 @> | ||
| if gid < inputLength then | ||
| let isUnique = (%predicate) gid inputLength inputArray // brahma error |
| // add and filter | ||
| |> Array.map Some | ||
| |> Array.fold add None | ||
| |> function |
There was a problem hiding this comment.
| if Utils.isFloat64Available context.ClDevice then | ||
| createTest ((=) 0.0) Expand.getSegmentPointers | ||
|
|
||
| createTest ((=) 0f) Expand.getSegmentPointers |
There was a problem hiding this comment.
Is it planned to use createTest with other testFun-ctions? If no, what is the reason to pass it as parameter?
| let (total: ClCell<_>) = scan q clArray zero | ||
|
|
||
| let actual = Array.zeroCreate<'a> clArray.Length | ||
| let actual = clArray.ToHostAndFree q | ||
| let actualSum = total.ToHostAndFree(q) |
| @@ -24,7 +36,7 @@ let checkResult isEqual actualKeys actualValues keys values reduceOp = | |||
| "Values must the same" | |||
| |> Utils.compareArrays isEqual actualValues expectedValues | |||
|
|
|||
| let makeTest isEqual reduce reduceOp (arrayAndKeys: (int * 'a) []) = | |||
| let private makeTest isEqual reduce reduceOp (arrayAndKeys: (int * 'a) []) = | |||
There was a problem hiding this comment.
Why `makeTest' sometimes private but sometimes -- not
|
|
||
| fun (queue: MailboxProcessor<_>) (matrix1: ClMatrix<'a>) (matrix2: ClMatrix<'b>) (mask: ClMatrix<_>) -> | ||
| match matrix1, matrix2, mask with | ||
| | ClMatrix.CSR m1, ClMatrix.CSC m2, ClMatrix.COO mask -> runCSRnCSC queue m1 m2 mask |> ClMatrix.COO |
There was a problem hiding this comment.
How can one to multiply two CSR matrix and get CSR matrix? Can one use CSR matrix as a mask?
There was a problem hiding this comment.
Or it is an old version form Artiom?
| fun (processor: MailboxProcessor<_>) lengths (segmentsPointers: Indices) (leftMatrix: ClMatrix.CSR<'a>) (rightMatrix: ClMatrix.CSR<'b>) -> | ||
|
|
||
| // Compute A positions | ||
| let APositions = zeroCreate processor DeviceOnly lengths |
There was a problem hiding this comment.
leftMatrixPositions? Same for other names below.
| match sum with | ||
| | Some value -> | ||
| let result = | ||
| ((%reduceOp) value values.[currentPosition]) // brahma error |
gsvgit
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of changes
What types of changes does your code introduce to GraphBLAS-sharp?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...