Skip to content

PHP implementation lacking a lot of functionality #101

Closed
@bcismariu

Description

@bcismariu

I was stunned to discover that only the fields mentioned in the Transmission documentation are supported. It turns out that if a setting is not defined in SparkPost\Transmission::$parameterMappings then it will not be taken into consideration, as there is no fallback to it: APIResource.php#L65

This prevents users from using additional settings (even though they are valid and supported by the SparkPost API), like, for instance options.ip_pool. On top of that, there is no easy way around it. The only option would be to wait for a future release in the hope that the new option would be supported by the official release.

My suggestion would be to allow for an easy fallback if the $mapKey is not defined in the $parameterMappings. As the name suggests, mappings should only map different settings to their corresponding official parameter: `'from' => 'content.from' and not filter through additional options that the user could use.
#67, #87

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions